Support Bitcoin Core 31.1 - #669
Conversation
Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
|
Appreciate the effort. I'm allergic to LLM output. Can you trim down the wall of text please. |
|
Oh woops I was too triggered by the LLM output to remember that dev is no longer on this repo. |
|
@tcharding can you please tell me in PR description what are the things that you want to be changed? Thanks |
I think the testing and screenshot verification bits are unnecessary, they are checked in CI. |
| alias test311='BITCOIND_EXE=/opt/bitcoin-31.1/bin/bitcoind cargo test --features=31_1' | ||
| alias test31='BITCOIND_EXE=/opt/bitcoin-31.0/bin/bitcoind cargo test --features=31_0' |
There was a problem hiding this comment.
| alias test311='BITCOIND_EXE=/opt/bitcoin-31.1/bin/bitcoind cargo test --features=31_1' | |
| alias test31='BITCOIND_EXE=/opt/bitcoin-31.0/bin/bitcoind cargo test --features=31_0' | |
| alias test31='BITCOIND_EXE=/opt/bitcoin-31.1/bin/bitcoind cargo test --features=31_1' |
This is just an example and better keep the format the same as the other versions that have point releases.
| #[cfg(feature = "31_1")] | ||
| #[allow(dead_code)] // Triggers in --all-features builds. | ||
| pub const VERSION: &str = "31.1"; | ||
|
|
||
| #[cfg(all(feature = "31_0", not(feature = "31_1")))] | ||
| #[allow(dead_code)] // Triggers in --all-features builds. | ||
| pub const VERSION: &str = "31.0"; |
There was a problem hiding this comment.
| #[cfg(feature = "31_1")] | |
| #[allow(dead_code)] // Triggers in --all-features builds. | |
| pub const VERSION: &str = "31.1"; | |
| #[cfg(all(feature = "31_0", not(feature = "31_1")))] | |
| #[allow(dead_code)] // Triggers in --all-features builds. | |
| pub const VERSION: &str = "31.0"; | |
| #[cfg(feature = "31_1")] | |
| #[allow(dead_code)] // Triggers in --all-features builds. | |
| pub const VERSION: &str = "31.1"; | |
| #[cfg(all(feature = "31_0", not(feature = "31_1")))] | |
| pub const VERSION: &str = "31.0"; |
|
Just remembered that we have moved to https://git.rust-bitcoin.org/rust-bitcoin/corepc. Please open this PR again there with the above changes. |
3 participants
Closes #657
Summary
310100).Testing
cargo check --manifest-path bitcoind/Cargo.toml --all-targets --no-default-features --features=31_1,downloadcargo test --features=31_1,download(integration_test)cargo test --features=latest,download(integration_test)cargo test --features=31_0,download(integration_test)cargo run -- --tests ... 31andcargo run all(verify)Screenshot verification